Add find* queries #44
Conversation
patrickhulce
left a comment
patrickhulce
left a comment
There was a problem hiding this comment.
thanks so much for the contribution @umpox!
|
|
||
| export interface IScopedQueryUtils extends IScopedQueryMethods { | ||
| getQueriesForElement(): IQueryUtils & IScopedQueryUtils | ||
| export interface IScopedQueryUtils extends BoundFunctions<IQueryMethods> { |
There was a problem hiding this comment.
I'm not sure BoundFunctions will work for us if it uses HTMLElement type inferences when we're using puppeteer ElementHandles
I know it's a pain, but maybe we just have to write our own type inference or just add waitForOpts?: WaitForElementOptions as optional to the signature of all the methods?
There was a problem hiding this comment.
We could duplicate BoundFunctions but with ElementHandle instead of HTMLElement? Everything else should be the same I think
|
|
||
| ## Known Limitations | ||
|
|
||
| - `waitForElement` method is not exposed. Puppeteer has its own set of wait utilities that somewhat conflict with the style used in `@testing-library/dom`. See [#3](https://github.com/testing-library/pptr-testing-library/issues/3). |
There was a problem hiding this comment.
I'm not sure we want to remove this note, but maybe convert it to cover waitForDomChange and waitForElementToBeRemoved as well and nudge to "use the find* methods instead".
There was a problem hiding this comment.
Check latest commit, writing documentation is hard 😁
There was a problem hiding this comment.
We can't use find* queries for waitForElementToBeRemoved, but I think we should be able to get that working nicely. Didn't get round to it in this PR but I'll raise an issue if anyone else wants to do it :)
There was a problem hiding this comment.
sounds good thanks! :)
umpox
force-pushed
the
add-findby-queries
branch
from
4c0d3e9 to
4d96f87
Compare
patrickhulce
left a comment
patrickhulce
left a comment
There was a problem hiding this comment.
thanks @umpox ! this is great stuff 👍
|
Any plans to release a publish version? |
3 participants
Adds all the
find*queries from dom-testing-library.This should be quite useful given the asynchronous nature of E2E tests.
I have also updated the README to remove
waitForElementas a known limitation, as it is deprecated indom-testing-libraryand the recommended alternative isfind*queries orwaitForwhich should now be supported!.